]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
extensionUtils: Check version variable for undefined first
authorJonas Dreßler <verdre@v0yd.nl>
Mon, 19 Nov 2018 11:26:16 +0000 (12:26 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Thu, 12 Sep 2019 10:24:49 +0000 (10:24 +0000)
Avoid a warning message when trying to access requiredArray[2] by
checking if its undefined first.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/96

js/misc/extensionUtils.js

index a05a884181b005c143209ee17dafa4195c83c108..2b3c11704fdc1e88796168fefaa7114814475d48 100644 (file)
@@ -165,8 +165,8 @@ function versionCheck(required, current) {
         let requiredArray = required[i].split('.');
         if (requiredArray[0] == major &&
             requiredArray[1] == minor &&
-            (requiredArray[2] == point ||
-             (requiredArray[2] == undefined && parseInt(minor) % 2 == 0)))
+            ((requiredArray[2] === undefined && parseInt(minor) % 2 == 0) ||
+             requiredArray[2] == point))
             return true;
     }
     return false;